Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 893383002: Never launch a new window when --no-startup-window is specified. (Closed)

Created:
5 years, 10 months ago by Will Harris
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Never launch a new window when --no-startup-window is specified. BUG=455070 TEST=manual, according to steps in bug. Committed: https://crrev.com/1ac1f1382fcafecdd9ee43cc5f1285989d5706dd Cr-Commit-Position: refs/heads/master@{#314603}

Patch Set 1 #

Total comments: 1

Patch Set 2 : bracket fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Will Harris
PTAL
5 years, 10 months ago (2015-02-04 05:12:31 UTC) #2
sky
LGTM https://codereview.chromium.org/893383002/diff/1/chrome/browser/ui/startup/startup_browser_creator.cc File chrome/browser/ui/startup/startup_browser_creator.cc (right): https://codereview.chromium.org/893383002/diff/1/chrome/browser/ui/startup/startup_browser_creator.cc#newcode605 chrome/browser/ui/startup/startup_browser_creator.cc:605: if (!process_startup && command_line.HasSwitch(switches::kNoStartupWindow)) { nit: no {}
5 years, 10 months ago (2015-02-04 18:10:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893383002/20001
5 years, 10 months ago (2015-02-04 18:15:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 19:11:51 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 19:14:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ac1f1382fcafecdd9ee43cc5f1285989d5706dd
Cr-Commit-Position: refs/heads/master@{#314603}

Powered by Google App Engine
This is Rietveld 408576698