ServiceWorker: Support SWRegistration.unregister() in SWGlobalScope [1/2]

content/browser/service_worker/service_worker_dispatcher_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_dispatcher_host.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/trace_event/trace_event.h"
 #include "content/browser/message_port_message_filter.h"
@@ skipping 543 matching lines @@
     BadMessageReceived();
 
   // Retrieve the registration associated with |version_id|.
   ServiceWorkerVersion* version = GetContext()->GetLiveVersion(version_id);
   if (!version)
     return;
   ServiceWorkerRegistration* registration =
       GetContext()->GetLiveRegistration(version->registration_id());
   DCHECK(registration);
 
+  // Set the document URL to the script url in order to allow
+  // register/unregister/getRegistration on ServiceWorkerGlobalScope.
+  provider_host->SetDocumentUrl(version->script_url());

[nhiroki, 2015/02/04 05:18:27]

I'm not really sure whether we have to call SetTopMostFrameUrl() for service
worker. falken@, do you know anything about it?

[kinuko, 2015/02/04 07:12:52]

Basically topmost_frame_url is used to lookup cookies settings to see if using
SW is allowed for the document, I'm not 100% sure but for ServiceWorkers we
probably can omit this.

[nhiroki, 2015/02/05 05:28:40]

I see. Already running worker wouldn't have to take care of the preference. I'm
going to keep this as is.

+
   ServiceWorkerRegistrationObjectInfo info;
   ServiceWorkerVersionAttributes attrs;
   GetRegistrationObjectInfoAndVersionAttributes(
       provider_host->AsWeakPtr(), registration, &info, &attrs);
 
   Send(new ServiceWorkerMsg_AssociateRegistrationWithServiceWorker(
       kDocumentMainThreadId, provider_id, info, attrs));
 }
 
 ServiceWorkerRegistrationHandle*
@@ skipping 364 matching lines @@
   ServiceWorkerHandle* handle = handles_.Lookup(handle_id);
   if (!handle) {
     BadMessageReceived();
     return;
   }
   handle->version()->StopWorker(
       base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
 }
 
 }  // namespace content