Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 893363002: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
wolenetz
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=wolenetz@chromium.org Committed: https://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2 Cr-Commit-Position: refs/heads/master@{#314786}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -182 lines) Patch
M media/audio/android/audio_android_unittest.cc View 9 chunks +18 lines, -21 lines 0 comments Download
M media/audio/android/audio_manager_android.h View 2 chunks +16 lines, -19 lines 0 comments Download
M media/audio/android/audio_record_input.h View 1 chunk +11 lines, -11 lines 0 comments Download
M media/audio/android/opensles_input.h View 1 chunk +11 lines, -11 lines 0 comments Download
M media/audio/android/opensles_output.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/base/android/audio_decoder_job.h View 1 2 chunks +9 lines, -10 lines 0 comments Download
M media/base/android/media_drm_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_player_bridge.h View 2 chunks +22 lines, -22 lines 0 comments Download
M media/base/android/media_source_player.h View 1 chunk +21 lines, -22 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 3 chunks +28 lines, -31 lines 0 comments Download
M media/base/android/video_decoder_job.h View 1 1 chunk +10 lines, -12 lines 0 comments Download
M media/midi/usb_midi_device_android.h View 1 chunk +3 lines, -4 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/video/capture/android/video_capture_device_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/video/capture/android/video_capture_device_factory_android.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:51:34 UTC) #1
wolenetz
On 2015/02/04 00:51:34, dcheng wrote: While I'm an OWNER of media/ and love this CL ...
5 years, 10 months ago (2015-02-04 21:23:57 UTC) #2
wolenetz
On 2015/02/04 21:23:57, wolenetz wrote: > On 2015/02/04 00:51:34, dcheng wrote: > > While I'm ...
5 years, 10 months ago (2015-02-04 21:25:58 UTC) #3
wolenetz
lgtm
5 years, 10 months ago (2015-02-04 21:32:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893363002/1
5 years, 10 months ago (2015-02-04 21:34:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/52129)
5 years, 10 months ago (2015-02-04 23:17:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893363002/1
5 years, 10 months ago (2015-02-04 23:20:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/23066)
5 years, 10 months ago (2015-02-05 01:10:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893363002/1
5 years, 10 months ago (2015-02-05 01:13:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/23148)
5 years, 10 months ago (2015-02-05 01:20:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893363002/20001
5 years, 10 months ago (2015-02-05 08:37:17 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 10:08:46 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 10:11:17 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/609028a4966aeddfce9f616bcdbab77838b01da2
Cr-Commit-Position: refs/heads/master@{#314786}

Powered by Google App Engine
This is Rietveld 408576698