Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 893353002: Rename VideoScheduler->VideoFramePipe. (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
Wez
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@scheduler_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename VideoScheduler->VideoFramePump. BUG=455818 Committed: https://crrev.com/10ce97b93303fbaae04e340537bb7d964ccf542b Cr-Commit-Position: refs/heads/master@{#314917}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -983 lines) Patch
M remoting/host/capture_scheduler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromeos/aura_desktop_capturer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/client_session.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/client_session.cc View 1 9 chunks +26 lines, -26 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + remoting/host/video_frame_pump.h View 1 5 chunks +14 lines, -15 lines 0 comments Download
A + remoting/host/video_frame_pump.cc View 1 13 chunks +36 lines, -36 lines 0 comments Download
A + remoting/host/video_frame_pump_unittest.cc View 1 15 chunks +33 lines, -33 lines 0 comments Download
D remoting/host/video_scheduler.h View 1 chunk +0 lines, -204 lines 0 comments Download
D remoting/host/video_scheduler.cc View 1 chunk +0 lines, -310 lines 0 comments Download
D remoting/host/video_scheduler_unittest.cc View 1 chunk +0 lines, -347 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/protocol_perftest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Sergey Ulanov
5 years, 10 months ago (2015-02-04 00:49:49 UTC) #2
Wez
nit: Associate this with the video scheduler refactoring bug #?
5 years, 10 months ago (2015-02-05 02:10:02 UTC) #3
Wez
On 2015/02/05 02:10:02, Wez wrote: > nit: Associate this with the video scheduler refactoring bug ...
5 years, 10 months ago (2015-02-05 02:21:41 UTC) #4
Wez
LGTM w/ the name fixed to VideoFramePump or VideoPump. (Or if there's a reason you ...
5 years, 10 months ago (2015-02-05 02:26:06 UTC) #5
Sergey Ulanov
On 2015/02/05 02:10:02, Wez wrote: > nit: Associate this with the video scheduler refactoring bug ...
5 years, 10 months ago (2015-02-05 19:32:15 UTC) #6
Sergey Ulanov
On 2015/02/05 02:21:41, Wez wrote: > On 2015/02/05 02:10:02, Wez wrote: > > nit: Associate ...
5 years, 10 months ago (2015-02-05 19:33:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893353002/20001
5 years, 10 months ago (2015-02-05 20:57:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/20890)
5 years, 10 months ago (2015-02-05 21:20:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893353002/40001
5 years, 10 months ago (2015-02-05 22:59:02 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-05 23:53:53 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 23:55:06 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/10ce97b93303fbaae04e340537bb7d964ccf542b
Cr-Commit-Position: refs/heads/master@{#314917}

Powered by Google App Engine
This is Rietveld 408576698