Correctly clear deprecated "proxy" pref set by data reduction proxy.

Correctly clear deprecated "proxy" pref set by data reduction proxy.

Clear empty "proxy" dictionary created by bug in data reduction proxy code.

BUG=448172
Committed: https://crrev.com/253dde8ec63036f390dd6315c3e156b0d7ab662b
Cr-Commit-Position: refs/heads/master@{#314593}

[Not at Google. Contact bengr, 2015-02-03 23:28:25]

kundaji@chromium.org changed reviewers:
+ bengr@chromium.org, eroman@chromium.org, mmenke@chromium.org

[Not at Google. Contact bengr, 2015-02-03 23:28:57]

bengr:
  chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

[mmenke, 2015-02-03 23:33:13]

Removing myself as a reviewer.  I really have no idea what's going on here.

[bengr, 2015-02-04 00:09:50]

https://codereview.chromium.org/893333002/diff/1/chrome/browser/net/spdyproxy...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
(left):

https://codereview.chromium.org/893333002/diff/1/chrome/browser/net/spdyproxy...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:49:
dict->SetString("mode", ProxyModeToString(ProxyPrefs::MODE_SYSTEM));
Should we also clear the pref if we encounter this setting?

[Not at Google. Contact bengr, 2015-02-04 00:44:14]

https://codereview.chromium.org/893333002/diff/1/chrome/browser/net/spdyproxy...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
(left):

https://codereview.chromium.org/893333002/diff/1/chrome/browser/net/spdyproxy...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:49:
dict->SetString("mode", ProxyModeToString(ProxyPrefs::MODE_SYSTEM));
On 2015/02/04 00:09:50, bengr wrote:
> Should we also clear the pref if we encounter this setting?

Safer not to, especially if we are patching this to M41.

As the cl stands, it will remove all "proxy" entries set by data reduction
proxy. Not sure we gain anything by clearing settings set by other components.

Although I do agree that no one should have to set mode to "system" since it is
the default.

[Not at Google. Contact bengr, 2015-02-04 00:44:43]

kundaji@chromium.org changed reviewers:
- mmenke@chromium.org

[bengr, 2015-02-04 00:50:34]

lgtm

[Not at Google. Contact bengr, 2015-02-04 17:05:47]

New patchsets have been uploaded after l-g-t-m from bengr@chromium.org

[bengr, 2015-02-04 17:08:28]

On 2015/02/04 00:50:34, bengr wrote:
> lgtm

Also, this should have a test. I'm ok with deferring that to another CL.

[Not at Google. Contact bengr, 2015-02-04 17:35:41]

The CQ bit was checked by kundaji@chromium.org

[commit-bot: I haz the power, 2015-02-04 17:36:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/893333002/20001

[commit-bot: I haz the power, 2015-02-04 18:42:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-04 18:43:59]

Patchset 2 (id:??) landed as
https://crrev.com/253dde8ec63036f390dd6315c3e156b0d7ab662b
Cr-Commit-Position: refs/heads/master@{#314593}