Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 893323003: Revert of [net] Subtract timestamps to determine if uploading file changed. (Closed)

Created:
5 years, 10 months ago by Noel Gordon
Modified:
5 years, 10 months ago
Reviewers:
asanka, Nate Chapin, mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [net] Subtract timestamps to determine if uploading file changed. (patchset #2 id:20001 of https://codereview.chromium.org/868253012/) Reason for revert: Seems this made http/tests/local/fileapi/send-sliced-dragged-file.html fail the blink bots. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=http/tests/local/fileapi/send-sliced-dragged-file.html Original issue's description: > [net] Subtract timestamps to determine if uploading file changed. > > UploadFileElementReader relies on checking the modified time of files > being uploaded to determine if a sliced file was modified during upload. > Clients of the net stack (in particular Blink) currently pass around the > expected modified time in a manner which cause the timestamp to lose > precision (E.g. converting to and from a double time_t). > > As a result the expected timestamp and the current timestamp as returned > by GetFileInfo() will not match exactly. Current code attempted to > compensate for this by converting both timestamps to (integer) time_t. > However, since the conversion rounds down, this check would only succeed > if the loss of precision of the expected timestamp also caused it to > round down. This is not always the case. (E.g. (epoch + 10.999999) will > become 10 when converted to time_t, but the expected timestamp may have > rounded up to (epoch + 11.0) in the meantime.) > > This patch compares the timestamps by checking if the magnitude of the > difference is less than one second. > > BUG=426465 > R=mmenke > > Committed: https://crrev.com/b77c8ffae588001875fb50ead987a147ca882bdb > Cr-Commit-Position: refs/heads/master@{#314397} TBR=mmenke@chromium.org,asanka@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=426465 Committed: https://crrev.com/7ccf4fab5d4473e431f1a289056033eea0b3dd43 Cr-Commit-Position: refs/heads/master@{#314451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -26 lines) Patch
M net/base/upload_file_element_reader.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M net/base/upload_file_element_reader_unittest.cc View 1 chunk +10 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Noel Gordon
Created Revert of [net] Subtract timestamps to determine if uploading file changed.
5 years, 10 months ago (2015-02-04 00:47:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893323003/1
5 years, 10 months ago (2015-02-04 00:47:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 00:48:46 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 00:50:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ccf4fab5d4473e431f1a289056033eea0b3dd43
Cr-Commit-Position: refs/heads/master@{#314451}

Powered by Google App Engine
This is Rietveld 408576698