Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 893313003: Adds histograms for physical keyboard autocorrect feature. (Closed)

Created:
5 years, 10 months ago by Shu Chen
Modified:
5 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds histograms for physical keyboard autocorrect feature. - InputMethod.PkCommit.Index - InputMethod.PkCommit.Type BUG=367631 TEST=None Committed: https://crrev.com/dcdf20ee99f921ef0d04fd8b69b7aedf884523cf Cr-Commit-Position: refs/heads/master@{#314736}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Shu Chen
Can you please review this cl? Thanks
5 years, 10 months ago (2015-02-04 00:38:17 UTC) #2
Ilya Sherman
Where is the code that emits these histograms? Can you please merge this CL into ...
5 years, 10 months ago (2015-02-04 01:18:10 UTC) #3
Ilya Sherman
LGTM % nits -- thanks. https://codereview.chromium.org/893313003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/893313003/diff/1/tools/metrics/histograms/histograms.xml#newcode10876 tools/metrics/histograms/histograms.xml:10876: + The suggestion index ...
5 years, 10 months ago (2015-02-04 18:57:03 UTC) #4
Shu Chen
Thanks for your review! https://codereview.chromium.org/893313003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/893313003/diff/1/tools/metrics/histograms/histograms.xml#newcode10876 tools/metrics/histograms/histograms.xml:10876: + The suggestion index (1-based) ...
5 years, 10 months ago (2015-02-05 02:05:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893313003/40001
5 years, 10 months ago (2015-02-05 02:07:48 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-05 03:38:30 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 03:40:24 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dcdf20ee99f921ef0d04fd8b69b7aedf884523cf
Cr-Commit-Position: refs/heads/master@{#314736}

Powered by Google App Engine
This is Rietveld 408576698