Chromium Code Reviews

Issue 893303002: Chromecast Android: fix for 100% crash when child process is launched. (Closed)

Created:
5 years, 10 months ago by gunsch
Modified:
5 years, 10 months ago
Reviewers:
lcwu1, kjoswiak
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast Android: fix for 100% crash when child process is launched. GPU process is launching before CrashDumpManager is initialized, calling into CastContentBrowserClient::GetAdditionalMappedFilesForProcess. Make sure to start CrashDumpManager earlier. R=lcwu@chromium.org,kjoswiak@chromium.org BUG=None Committed: https://crrev.com/8ce7fd4137da4b4d5077361b3995fd5a75d4ae8b Cr-Commit-Position: refs/heads/master@{#314449}

Patch Set 1 #

Patch Set 2 : updates commit msg #

Unified diffs Side-by-side diffs Stats (+11 lines, -11 lines)
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +11 lines, -11 lines 0 comments

Messages

Total messages: 9 (2 generated)
gunsch
5 years, 10 months ago (2015-02-03 22:38:30 UTC) #1
kjoswiak
lgtm
5 years, 10 months ago (2015-02-03 23:42:12 UTC) #2
lcwu1
lgtm, but I am not sure I understand what you meant by "100% crashfix" in ...
5 years, 10 months ago (2015-02-03 23:54:12 UTC) #3
gunsch
On 2015/02/03 23:54:12, lcwu1 wrote: > lgtm, but I am not sure I understand what ...
5 years, 10 months ago (2015-02-04 00:00:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893303002/20001
5 years, 10 months ago (2015-02-04 00:01:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 00:47:02 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 00:48:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ce7fd4137da4b4d5077361b3995fd5a75d4ae8b
Cr-Commit-Position: refs/heads/master@{#314449}

Powered by Google App Engine