Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 893273003: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
sgurun-gerrit only
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=sgurun@chromium.org Committed: https://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9 Cr-Commit-Position: refs/heads/master@{#314467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -56 lines) Patch
M android_webview/common/aw_content_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/lib/aw_browser_dependency_factory_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.h View 2 chunks +3 lines, -4 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.h View 1 chunk +25 lines, -28 lines 0 comments Download
M android_webview/renderer/aw_message_port_client.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_permission_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_render_frame_ext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_render_process_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/renderer/aw_render_view_ext.h View 1 chunk +6 lines, -6 lines 0 comments Download
M android_webview/renderer/print_render_frame_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:46:24 UTC) #1
sgurun-gerrit only
On 2015/02/04 00:46:24, dcheng wrote: lgtm
5 years, 10 months ago (2015-02-04 00:59:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893273003/1
5 years, 10 months ago (2015-02-04 01:12:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 01:50:45 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 01:52:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f9f934ab10ff8bf1922ccc23e449167237d98b9
Cr-Commit-Position: refs/heads/master@{#314467}

Powered by Google App Engine
This is Rietveld 408576698