Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 893263003: Only close \Device\DeviceApi for renderer processes. (Closed)

Created:
5 years, 10 months ago by Will Harris
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

On utility/ppapi processes, cfgmgr32.dll opens a to this handle and then will raise an exception on exit if FLG_ENABLE_HANDLE_EXCEPTIONS is set in gflags. This flag is set on Windows 10 builds. BUG=452613 Committed: https://crrev.com/787196b975d55ce1af011577276886489300161c Cr-Commit-Position: refs/heads/master@{#314497}

Patch Set 1 : take 1: simply do not close handle on win10 #

Patch Set 2 : take 2: only close \device\deviceapi on renderer processes #

Patch Set 3 : add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/common/sandbox_win.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Will Harris
This is a temp fix for the huge win10 crasher. Since we can repro this ...
5 years, 10 months ago (2015-02-03 22:01:24 UTC) #2
Will Harris
On 2015/02/03 22:01:24, Will Harris wrote: > This is a temp fix for the huge ...
5 years, 10 months ago (2015-02-03 23:39:22 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-04 00:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893263003/40001
5 years, 10 months ago (2015-02-04 00:49:26 UTC) #7
cpu_(ooo_6.6-7.5)
lgtm again
5 years, 10 months ago (2015-02-04 01:28:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/22580)
5 years, 10 months ago (2015-02-04 02:29:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893263003/40001
5 years, 10 months ago (2015-02-04 03:13:48 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-04 04:02:57 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 04:04:03 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/787196b975d55ce1af011577276886489300161c
Cr-Commit-Position: refs/heads/master@{#314497}

Powered by Google App Engine
This is Rietveld 408576698