Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 893233003: Fix flaky DevToolsClientBackendTest (Closed)

Created:
5 years, 10 months ago by Zhen Wang
Modified:
5 years, 10 months ago
Reviewers:
nednguyen, chrishenry
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, telemetry-reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky DevToolsClientBackendTest testGetUpdatedInspectableContexts should only run when tab control is supported. BUG=452277 Committed: https://crrev.com/c35c0321444f4d571059c8da4621b720f2d0946e Cr-Commit-Position: refs/heads/master@{#314689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Zhen Wang
ptal
5 years, 10 months ago (2015-02-04 23:11:47 UTC) #2
nednguyen
On 2015/02/04 23:11:47, Zhen Wang wrote: > ptal LGTM if this fixes the test for ...
5 years, 10 months ago (2015-02-04 23:31:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893233003/1
5 years, 10 months ago (2015-02-05 00:11:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 00:50:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:53:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c35c0321444f4d571059c8da4621b720f2d0946e
Cr-Commit-Position: refs/heads/master@{#314689}

Powered by Google App Engine
This is Rietveld 408576698