Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 893193005: Remove duplicated CSSValueNone checks (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove duplicated CSSValueNone checks In these cases instead of duplicated code to create the None identifier, use the validPrimitive machinery instead. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 6 chunks +14 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL.
5 years, 9 months ago (2015-03-24 19:37:32 UTC) #2
Timothy Loh
ok, lgtm
5 years, 9 months ago (2015-03-24 23:41:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893193005/1
5 years, 9 months ago (2015-03-25 00:03:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/48810)
5 years, 9 months ago (2015-03-25 03:53:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893193005/1
5 years, 9 months ago (2015-03-25 11:05:36 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 12:32:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192529

Powered by Google App Engine
This is Rietveld 408576698