Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: services/view_manager/client_connection.h

Issue 893183003: De-client the ViewManager interfaces (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/view_manager/BUILD.gn ('k') | services/view_manager/client_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/view_manager/client_connection.h
diff --git a/services/view_manager/client_connection.h b/services/view_manager/client_connection.h
index 7f5050808ba8a58dd53c20f043b7da1e4a8653c5..acbfc737c79f5946fe5f44337e30f263ed328841 100644
--- a/services/view_manager/client_connection.h
+++ b/services/view_manager/client_connection.h
@@ -19,7 +19,8 @@ class ViewManagerServiceImpl;
// to the view manager.
class ClientConnection {
public:
- explicit ClientConnection(scoped_ptr<ViewManagerServiceImpl> service);
+ ClientConnection(scoped_ptr<ViewManagerServiceImpl> service,
+ mojo::ViewManagerClient* client);
virtual ~ClientConnection();
ViewManagerServiceImpl* service() { return service_.get(); }
@@ -27,9 +28,6 @@ class ClientConnection {
mojo::ViewManagerClient* client() { return client_; }
- protected:
- void set_client(mojo::ViewManagerClient* client) { client_ = client; }
-
private:
scoped_ptr<ViewManagerServiceImpl> service_;
mojo::ViewManagerClient* client_;
@@ -41,9 +39,11 @@ class ClientConnection {
class DefaultClientConnection : public ClientConnection,
public mojo::ErrorHandler {
public:
- DefaultClientConnection(scoped_ptr<ViewManagerServiceImpl> service_impl,
- ConnectionManager* connection_manager,
- mojo::ScopedMessagePipeHandle handle);
+ DefaultClientConnection(
+ scoped_ptr<ViewManagerServiceImpl> service_impl,
+ ConnectionManager* connection_manager,
+ mojo::InterfaceRequest<mojo::ViewManagerService> service_request,
+ mojo::ViewManagerClientPtr client);
~DefaultClientConnection() override;
private:
@@ -52,6 +52,7 @@ class DefaultClientConnection : public ClientConnection,
ConnectionManager* connection_manager_;
mojo::Binding<mojo::ViewManagerService> binding_;
+ mojo::ViewManagerClientPtr client_;
DISALLOW_COPY_AND_ASSIGN(DefaultClientConnection);
};
« no previous file with comments | « services/view_manager/BUILD.gn ('k') | services/view_manager/client_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698