Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: mojo/services/view_manager/public/interfaces/view_manager.mojom

Issue 893183003: De-client the ViewManager interfaces (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/public/interfaces/view_manager.mojom
diff --git a/mojo/services/view_manager/public/interfaces/view_manager.mojom b/mojo/services/view_manager/public/interfaces/view_manager.mojom
index 23238d5d8d57e5ce89ec58b7cfbdcca3e47e31b4..8e73c85c9634fcc8c38159f4a4e722a94eb2e865 100644
--- a/mojo/services/view_manager/public/interfaces/view_manager.mojom
+++ b/mojo/services/view_manager/public/interfaces/view_manager.mojom
@@ -35,7 +35,6 @@ enum ErrorCode {
// and the lower 16 the id assigned by the client.
//
// The root view is identified with a connection id of 0, and value of 1.
-[Client=ViewManagerClient]
interface ViewManagerService {
// Creates a new view with the specified id. It is up to the client to ensure
// the id is unique to the connection (the id need not be globally unique).
@@ -139,7 +138,6 @@ interface ViewManagerService {
// Changes to views are not sent to the connection that originated the
// change. For example, if connection 1 changes the bounds of a view by calling
// SetBounds(), connection 1 does not receive OnViewBoundsChanged().
-[Client=ViewManagerService]
interface ViewManagerClient {
// Invoked when the client application has been embedded at |root|.
// See Embed() on ViewManagerService for more details. |window_manager_pipe|
@@ -147,6 +145,7 @@ interface ViewManagerClient {
OnEmbed(uint16 connection_id,
string embedder_url,
ViewData root,
+ ViewManagerService? view_manager_service,
ServiceProvider&? services,
ServiceProvider? exposed_services,
handle<message_pipe> window_manager_pipe);

Powered by Google App Engine
This is Rietveld 408576698