Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 8931011: Update corelib to revised factory syntax. (Closed)

Created:
9 years ago by regis
Modified:
8 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update corelib to revised factory syntax.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -43 lines) Patch
M corelib/src/date.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/duration.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/exceptions.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/future.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M corelib/src/implementation/hash_map_set.dart View 2 chunks +5 lines, -7 lines 0 comments Download
M corelib/src/implementation/linked_hash_map.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M corelib/src/implementation/queue.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M corelib/src/isolate.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/map.dart View 3 chunks +3 lines, -9 lines 0 comments Download
M corelib/src/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/promise.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M corelib/src/queue.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/regexp.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/set.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M corelib/src/stopwatch.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/string_buffer.dart View 1 chunk +1 line, -1 line 0 comments Download
M corelib/src/time_zone.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
regis
I will not submit this before you guys tell me that frog and dartc can ...
9 years ago (2011-12-13 20:40:02 UTC) #1
Jennifer Messerly
On 2011/12/13 20:40:02, regis wrote: > I will not submit this before you guys tell ...
9 years ago (2011-12-15 01:54:17 UTC) #2
Jennifer Messerly
On 2011/12/15 01:54:17, John Messerly wrote: > On 2011/12/13 20:40:02, regis wrote: > > I ...
9 years ago (2011-12-15 02:15:42 UTC) #3
zundel
LGTM I went ahead and submitted this under code review http://codereview.chromium.org//8989015 as svn rev 2629.
9 years ago (2011-12-20 12:55:57 UTC) #4
regis
8 years, 11 months ago (2012-01-06 19:00:05 UTC) #5
On 2011/12/20 12:55:57, zundel wrote:
> LGTM
> 
> I went ahead and submitted this under code review
> http://codereview.chromium.org//8989015 as svn rev 2629.

I closed this cl, since you submitted it separately.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698