Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 8931002: Merge 101998 - "Raw" pseudo selectors don't match if immediately after a child or descendant comb... (Closed)

Created:
9 years, 2 months ago by tkent
Modified:
9 years, 2 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 101998 - "Raw" pseudo selectors don't match if immediately after a child or descendant combinator https://bugs.webkit.org/show_bug.cgi?id=72933 Source/WebCore: Remove shortcut that prevents universal selectors from being created before shadow pseudo-elements. Reviewed by Antti Koivisto. * css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): LayoutTests: Add tests cases for "raw" shadow pseudo-element selectors with various combinators. Also add cases with explicit universal '*' selector. Reviewed by Antti Koivisto. * fast/css/css-selector-text-expected.txt: * fast/css/css-selector-text.html: * fast/css/css-set-selector-text-expected.txt: * fast/css/css-set-selector-text.html: * fast/css/unknown-pseudo-element-matching-expected.txt: * fast/css/unknown-pseudo-element-matching.html: TBR=rolandsteiner@chromium.org BUG=97744 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -48 lines) Patch
M LayoutTests/fast/css/css-selector-text.html View 1 chunk +18 lines, -10 lines 0 comments Download
M LayoutTests/fast/css/css-selector-text-expected.txt View 1 chunk +16 lines, -10 lines 0 comments Download
M LayoutTests/fast/css/css-set-selector-text.html View 1 chunk +18 lines, -10 lines 0 comments Download
M LayoutTests/fast/css/css-set-selector-text-expected.txt View 1 chunk +16 lines, -10 lines 0 comments Download
M LayoutTests/fast/css/unknown-pseudo-element-matching.html View 5 chunks +17 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/unknown-pseudo-element-matching-expected.txt View 5 chunks +40 lines, -0 lines 0 comments Download
M Source/WebCore/css/CSSParser.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
9 years, 2 months ago (2011-12-13 06:36:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698