Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: sky/engine/core/css/parser/CSSPropertyParser.cpp

Issue 893093002: Delete remaining masks dead code. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/StylePropertySerializer.cpp ('k') | sky/engine/core/css/resolver/CSSToStyleMap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/parser/CSSPropertyParser.cpp
diff --git a/sky/engine/core/css/parser/CSSPropertyParser.cpp b/sky/engine/core/css/parser/CSSPropertyParser.cpp
index 6212e8d2914e1bf9827d6b6638675c3cb39d5fef..4beb299fc4f4d3d7fd7d26e63f7ad8004dbafc91 100644
--- a/sky/engine/core/css/parser/CSSPropertyParser.cpp
+++ b/sky/engine/core/css/parser/CSSPropertyParser.cpp
@@ -1767,7 +1767,7 @@ PassRefPtr<CSSValue> CSSPropertyParser::parseAttr(CSSParserValueList* args)
return nullptr;
String attrName = a->string;
- // CSS allows identifiers with "-" at the start, like "-webkit-mask-image".
+ // CSS allows identifiers with "-" at the start, like "-webkit-foo".
// But HTML attribute names can't have those characters, and we should not
// even parse them inside attr().
if (attrName[0] == '-')
@@ -2227,9 +2227,9 @@ PassRefPtr<CSSValue> CSSPropertyParser::parseFillSize(CSSPropertyID propId, bool
parsedValue2 = createPrimitiveNumericValue(value);
}
} else if (!parsedValue2 && propId == CSSPropertyWebkitBackgroundSize) {
+ // FIXME(sky): Remove webkit-background-size.
// For backwards compatibility we set the second value to the first if it is omitted.
- // We only need to do this for -webkit-background-size. It should be safe to let masks match
- // the real property.
+ // We only need to do this for -webkit-background-size.
parsedValue2 = parsedValue1;
}
@@ -4656,8 +4656,8 @@ bool CSSPropertyParser::parseBorderImageSlice(CSSPropertyID propId, RefPtr<CSSBo
}
if (context.allowFinalCommit()) {
- // FIXME: For backwards compatibility, -webkit-border-image, -webkit-mask-box-image and -webkit-box-reflect have to do a fill by default.
- // FIXME: What do we do with -webkit-box-reflect and -webkit-mask-box-image? Probably just have to leave them filling...
+ // FIXME(sky): Remove this.
+ // FIXME: For backwards compatibility, -webkit-border-image has to do a fill by default.
if (propId == CSSPropertyWebkitBorderImage)
context.commitFill();
« no previous file with comments | « sky/engine/core/css/StylePropertySerializer.cpp ('k') | sky/engine/core/css/resolver/CSSToStyleMap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698