Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 893093002: Delete remaining masks dead code. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete remaining masks dead code. Removes the straggling code related to masks now that we've removed the CSS properties. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/690c3953605a83d7d3ca6ac8adb2bfeedd3473f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -219 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 6 chunks +17 lines, -33 lines 0 comments Download
M sky/engine/core/css/SVGCSSValueKeywords.in View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/StylePropertySerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/core/css/resolver/CSSToStyleMap.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/CSSToStyleMap.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M sky/engine/core/css/resolver/StyleAdjuster.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 2 chunks +5 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/style/FillLayer.h View 7 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/style/FillLayer.cpp View 7 chunks +2 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/style/NinePieceImage.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 5 chunks +0 lines, -60 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 2 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 4 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -14 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsTypes.h View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/public/platform/WebLayer.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 10 months ago (2015-02-03 00:53:46 UTC) #2
ojan
5 years, 10 months ago (2015-02-03 02:56:52 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
690c3953605a83d7d3ca6ac8adb2bfeedd3473f7.

Powered by Google App Engine
This is Rietveld 408576698