Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 893083002: Lower sync breakpad upload rate to 1% (Closed)

Created:
5 years, 10 months ago by Nicolas Zea
Modified:
5 years, 10 months ago
Reviewers:
stanisc
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lower sync breakpad upload rate to 1% 1% is a lot less noisy than 15%, and still gives up some visibility into new regressions. BUG=384552 Committed: https://crrev.com/e49269bdf5f360657391352c2b68b9d2b58e470a Cr-Commit-Position: refs/heads/master@{#314230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Nicolas Zea
PTAL
5 years, 10 months ago (2015-02-02 22:56:34 UTC) #2
stanisc
lgtm As I understand this will lower frequency of some already investigated crashes, for example ...
5 years, 10 months ago (2015-02-02 23:07:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893083002/1
5 years, 10 months ago (2015-02-02 23:52:07 UTC) #5
Nicolas Zea
On 2015/02/02 23:07:31, stanisc wrote: > lgtm > As I understand this will lower frequency ...
5 years, 10 months ago (2015-02-02 23:52:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 00:57:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 00:58:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e49269bdf5f360657391352c2b68b9d2b58e470a
Cr-Commit-Position: refs/heads/master@{#314230}

Powered by Google App Engine
This is Rietveld 408576698