src/isolate.cc - Issue 893073006: Add map-based read barrier to WeakCell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 893073006: Add map-based read barrier to WeakCell Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix merge Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 37020da1559b70828dfceedf5eb75cb32391817b..f9a6edfb383ad21437d59859394176645d26b2a9 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -2604,7 +2604,7 @@ void Isolate::CheckDetachedContextsAfterGC() {

WeakCell* cell = WeakCell::cast(detached_contexts->get(i + 1));

if (mark_sweeps > 3) {

PrintF("detached context 0x%p\n survived %d GCs (leak?)\n",

- static_cast<void*>(cell->value()), mark_sweeps);

+ static_cast<void*>(cell->ValueNoReadBarrier()), mark_sweeps);

}

if (length == new_length) {

« no previous file with comments | « src/ic/ia32/ic-compiler-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »