src/ic/ia32/ic-compiler-ia32.cc - Issue 893073006: Add map-based read barrier to WeakCell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ia32/ic-compiler-ia32.cc

Issue 893073006: Add map-based read barrier to WeakCell Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix merge Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ia32/ic-compiler-ia32.cc

diff --git a/src/ic/ia32/ic-compiler-ia32.cc b/src/ic/ia32/ic-compiler-ia32.cc

index 076a2ac9ceeee006039c1581e0ff84d3ef72f98a..137b556293f4a00795ca72dd88e9ca9043aaec8a 100644

--- a/src/ic/ia32/ic-compiler-ia32.cc

+++ b/src/ic/ia32/ic-compiler-ia32.cc

@@ -115,7 +115,7 @@ Handle<Code> PropertyICCompiler::CompileKeyedStorePolymorphic(

Label next_map;

__ j(not_equal, &next_map, Label::kNear);

Handle<WeakCell> cell = Map::WeakCellForMap(transitioned_maps->at(i));

- __ LoadWeakValue(transition_map(), cell, &miss);

+ __ LoadWeakValue(transition_map(), cell, scratch2(), &miss);

__ jmp(handler_stubs->at(i), RelocInfo::CODE_TARGET);

__ bind(&next_map);

}

« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »