Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: src/ia32/macro-assembler-ia32.h

Issue 893073006: Add map-based read barrier to WeakCell Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix merge Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/macro-assembler-ia32.h
diff --git a/src/ia32/macro-assembler-ia32.h b/src/ia32/macro-assembler-ia32.h
index e62c7d8b4d23d6013b0cddda89db67be31c96773..adbcdc0409b88841daf27363ebd78522189769f8 100644
--- a/src/ia32/macro-assembler-ia32.h
+++ b/src/ia32/macro-assembler-ia32.h
@@ -298,11 +298,22 @@ class MacroAssembler: public Assembler {
// Compare the given value and the value of weak cell.
void CmpWeakValue(Register value, Handle<WeakCell> cell, Register scratch);
- void GetWeakValue(Register value, Handle<WeakCell> cell);
+ void GetWeakValue(Register value, Register scratch, Handle<WeakCell> cell);
+
+ // Gets the given value without triggering the read barrier (you must
+ // immediately discard the value returned). You might want to use
+ // CmpWeakValue instead.
+ void GetWeakValueNoReadBarrier(Register value, Handle<WeakCell> cell);
+
+ // Load the value of the weak cell in the value register. Branch to the given
+ // miss label if the weak cell was cleared.
+ void LoadWeakValue(Register value, Handle<WeakCell> cell, Register scratch,
+ Label* miss);
// Load the value of the weak cell in the value register. Branch to the given
// miss label if the weak cell was cleared.
- void LoadWeakValue(Register value, Handle<WeakCell> cell, Label* miss);
+ void LoadWeakValueNoReadBarrier(Register value, Handle<WeakCell> cell,
+ Label* miss);
// ---------------------------------------------------------------------------
// JavaScript invokes
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698