src/hydrogen.cc - Issue 893073006: Add map-based read barrier to WeakCell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 893073006: Add map-based read barrier to WeakCell Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix merge Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index e40316f74ab5c12c42fa61e9e161682b20392162..bc78966f3a681f8db25401ee3bcc745a75d78196 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -3068,7 +3068,7 @@ void HGraphBuilder::BuildCompareNil(HValue* value, Type* type,

HValue* cell =

Add<HConstant>(Map::WeakCellForMap(type->Classes().Current()));

HValue* expected_map = Add<HLoadNamedField>(

- cell, nullptr, HObjectAccess::ForWeakCellValue());

+ cell, nullptr, HObjectAccess::ForWeakCellValueComparison());

HValue* map =

Add<HLoadNamedField>(value, nullptr, HObjectAccess::ForMap());

IfBuilder map_check(this);

« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »