src/factory.cc - Issue 893073006: Add map-based read barrier to WeakCell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 893073006: Add map-based read barrier to WeakCell Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix merge Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index ef695cf337d0acfddda343be09407b9df19f43b4..8b029635cea36f0ac5fa868f6e65796d3d7af21a 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2274,7 +2274,7 @@ Handle<Map> Factory::ObjectLiteralMapFromCache(Handle<Context> context,

if (result->IsWeakCell()) {

WeakCell* cell = WeakCell::cast(result);

if (!cell->cleared()) {

- return handle(Map::cast(cell->value()), isolate());

+ return handle(Map::cast(cell->value(isolate()->heap())), isolate());

}

« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »