Add map-based read barrier to WeakCell

src/objects-debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/disasm.h"
 #include "src/disassembler.h"
 #include "src/heap/objects-visiting.h"
 #include "src/jsregexp.h"
 #include "src/macro-assembler.h"
+#include "src/objects-inl.h"
 #include "src/ostreams.h"
 
 namespace v8 {
 namespace internal {
 
 #ifdef VERIFY_HEAP
 
 void Object::ObjectVerify() {
   if (IsSmi()) {
     Smi::cast(this)->SmiVerify();
@@ skipping 618 matching lines @@
 
 void PropertyCell::PropertyCellVerify() {
   CHECK(IsPropertyCell());
   VerifyObjectField(kValueOffset);
   VerifyObjectField(kTypeOffset);
 }
 
 
 void WeakCell::WeakCellVerify() {
   CHECK(IsWeakCell());
-  VerifyObjectField(kValueOffset);
+  Object* value = ValueNoReadBarrier();
+  VerifyPointer(value);
   VerifyObjectField(kNextOffset);
 }
 
 
 void Code::CodeVerify() {
   CHECK(IsAligned(reinterpret_cast<intptr_t>(instruction_start()),
                   kCodeAlignment));
   relocation_info()->ObjectVerify();
   Address last_gc_pc = NULL;
   Isolate* isolate = GetIsolate();
@@ skipping 575 matching lines @@
 }
 
 
 // Estimates if there is a path from the object to a context.
 // This function is not precise, and can return false even if
 // there is a path to a context.
 bool CanLeak(Object* obj, Heap* heap, bool skip_weak_cell) {
   if (!obj->IsHeapObject()) return false;
   if (obj->IsWeakCell()) {
     if (skip_weak_cell) return false;
-    return CanLeak(WeakCell::cast(obj)->value(), heap, skip_weak_cell);
+    return CanLeak(WeakCell::cast(obj)->value(heap), heap, skip_weak_cell);
   }
   if (obj->IsCell()) {
     return CanLeak(Cell::cast(obj)->value(), heap, skip_weak_cell);
   }
   if (obj->IsPropertyCell()) {
     return CanLeak(PropertyCell::cast(obj)->value(), heap, skip_weak_cell);
   }
   if (obj->IsContext()) return true;
   if (obj->IsMap()) {
     Map* map = Map::cast(obj);
@@ skipping 17 matching lines @@
                          ? it.rinfo()->target_cell()
                          : it.rinfo()->target_object();
     CHECK(!CanLeak(target, heap, skip_weak_cell));
   }
 }
 
 
 #endif  // DEBUG
 
 } }  // namespace v8::internal