Issue 893073005: Revert of Fixing inbox test by adding sha1 files and enabling inbox benchmark again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 893073005: Revert of Fixing inbox test by adding sha1 files and enabling inbox benchmark again. (Closed)

Created:
5 years, 10 months ago by oystein (OOO til 10th of July)

Modified:
5 years, 10 months ago

Reviewers:
manisharora, dtu, aiolos0, sullivan1, tonyg, tonyg_google

CC:
mayankgupta, rachit_google.com

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fixing inbox test by adding sha1 files and enabling inbox benchmark again. (patchset #1 id:1 of https://codereview.chromium.org/883693006/) Reason for revert: Still flaky on Mac 10.9 Perf (5) Original issue's description: > Fixing inbox test by adding sha1 files and enabling inbox benchmark again. > > BUG=452257 > > Committed: https://crrev.com/fd0b94cd15337a91d167a3b931ac4252e1174042 > Cr-Commit-Position: refs/heads/master@{#314164} TBR=sullivan@google.com,tonyg@google.com,aiolos@google.com,dtu@chromium.org,tonyg@chromium.org,manisharora@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452257 Committed: https://crrev.com/59a02ac9983dd27d058e4901ed4101fae6e144dd Cr-Commit-Position: refs/heads/master@{#314245}

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	tools/perf/benchmarks/inbox_benchmark.py	View	1 chunk	+13 lines, -11 lines	0 comments	Download
D	tools/perf/page_sets/data/inbox_credentials.json.sha1	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tools/perf/page_sets/data/inbox_data_000.wpr.sha1	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

oystein (OOO til 10th of July)

Created Revert of Fixing inbox test by adding sha1 files and enabling inbox benchmark again.

5 years, 10 months ago (2015-02-03 02:12:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893073005/1

5 years, 10 months ago (2015-02-03 02:13:36 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-03 02:15:58 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/59a02ac9983dd27d058e4901ed4101fae6e144dd
Cr-Commit-Position: refs/heads/master@{#314245}