Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 893013003: Revert of Input type url with line break and leading-trailing whitespace should be stripped. (Closed)

Created:
5 years, 10 months ago by prashant.hiremath
Modified:
5 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, keishi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Input type url with line break and leading-trailing whitespace should be stripped. (patchset #2 id:20001 of https://codereview.chromium.org/836113002/) Reason for revert: Reverting this Patch, as this will break the old behavior of browser in case of user types spaces into input box type url. It need to be discussed with wider audience, what should be the correct behavior in case of user inputting and JavaScript setting the input value, to reland this patch. Original issue's description: > Input type url with line break and leading-trailing whitespace should be stripped. > > According to spec https://html.spec.whatwg.org/multipage/forms.html#url-state-%28type=url%29, > we have to strip the line break and leading-trailing whitespaces from the url value, so added santization > algorithm to strip the line break and leading-trailing whitespaces. > Firefox works according to spec and strips the linebreak and whitespaces from value. > > BUG=446108 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188106 TBR=eae@chromium.org,mlamouri@chromium.org,tkent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446108 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
D LayoutTests/fast/forms/url-with-line-break-and-whitespace.html View 1 chunk +0 lines, -22 lines 0 comments Download
M Source/core/html/forms/URLInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/URLInputType.cpp View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
prashant.hiremath
Created Revert of Input type url with line break and leading-trailing whitespace should be stripped.
5 years, 10 months ago (2015-02-04 11:54:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893013003/1
5 years, 10 months ago (2015-02-04 11:55:03 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-04 11:55:05 UTC) #4
mlamouri (slow - plz ping)
On 2015/02/04 at 11:55:05, commit-bot wrote: > No LGTM from a valid reviewer yet. Only ...
5 years, 10 months ago (2015-02-04 12:17:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893013003/1
5 years, 10 months ago (2015-02-05 02:07:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 02:08:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189534

Powered by Google App Engine
This is Rietveld 408576698