Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 893003004: Temporary logging to help ANR dissection (Closed)

Created:
5 years, 10 months ago by aruslan
Modified:
5 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporary logging to help ANR dissection BUG=446578 Committed: https://crrev.com/e5e01b7d7fdbf41b74b40d7713c546db20e41c72 Cr-Commit-Position: refs/heads/master@{#314644}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java View 1 chunk +2 lines, -0 lines 2 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/child_accounts/ChildAccountService.java View 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
aruslan
PTAL, thanks! I'll revert once I have data; let me know if there is a ...
5 years, 10 months ago (2015-02-02 22:53:37 UTC) #2
Ted C
https://codereview.chromium.org/893003004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java (right): https://codereview.chromium.org/893003004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java#newcode176 chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java:176: android.util.Log.i(TAG, "before executing " + name + " call"); ...
5 years, 10 months ago (2015-02-04 19:53:28 UTC) #3
aruslan
https://codereview.chromium.org/893003004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java (right): https://codereview.chromium.org/893003004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java#newcode176 chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java:176: android.util.Log.i(TAG, "before executing " + name + " call"); ...
5 years, 10 months ago (2015-02-04 21:07:48 UTC) #4
Ted C
On 2015/02/04 21:07:48, aruslan wrote: > https://codereview.chromium.org/893003004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java > File > chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java > (right): > > ...
5 years, 10 months ago (2015-02-04 21:08:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893003004/1
5 years, 10 months ago (2015-02-04 21:15:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 21:46:44 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:48:08 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e5e01b7d7fdbf41b74b40d7713c546db20e41c72
Cr-Commit-Position: refs/heads/master@{#314644}

Powered by Google App Engine
This is Rietveld 408576698