Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2586)

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

Issue 893003002: Data Reduction Proxy class ownership updates and Settings cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
index 57fbf651ca856c755741eba0a145df0426c780db..afec05a8f0e0f931416a64fb20a0c2dd7f7d7f65 100644
--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
@@ -5,7 +5,6 @@
#ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
#define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
-#include "base/memory/scoped_ptr.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
#include "components/keyed_service/core/keyed_service.h"
@@ -15,15 +14,9 @@ class PrefService;
}
namespace data_reduction_proxy {
-class DataReductionProxyConfigurator;
+class DataReductionProxyConfig;
class DataReductionProxyIOData;
class DataReductionProxyEventStore;
-class DataReductionProxyParams;
-}
-
-namespace net {
-class NetLog;
-class URLRequestContextGetter;
}
class PrefService;
@@ -34,21 +27,17 @@ class DataReductionProxyChromeSettings
: public data_reduction_proxy::DataReductionProxySettings,
public KeyedService {
public:
- // Constructs a settings object with the given configuration parameters.
- // Construction and destruction must happen on the UI thread.
- explicit DataReductionProxyChromeSettings(
- scoped_ptr<data_reduction_proxy::DataReductionProxyParams> params);
+ // Constructs a settings object. Construction and destruction must happen on
+ // the UI thread.
+ DataReductionProxyChromeSettings();
// Destructs the settings object.
~DataReductionProxyChromeSettings() override;
- // Initialize the settings object with the given configurator, prefs services,
- // and request context.
+ // Initialize the settings object with the given prefs services, and io_data.
void InitDataReductionProxySettings(
data_reduction_proxy::DataReductionProxyIOData* io_data,
- PrefService* profile_prefs,
- PrefService* local_state_prefs,
- net::URLRequestContextGetter* request_context);
+ PrefService* profile_prefs);
// Gets the client type for the data reduction proxy.
static data_reduction_proxy::Client GetClient();

Powered by Google App Engine
This is Rietveld 408576698