Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc

Issue 893003002: Data Reduction Proxy class ownership updates and Settings cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sgurun CR comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
index 595edf10c28fef86a06bdb53c79221a4b2805944..7e6d12c34b7b5179b17d483d237e126ee5b8c4c6 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
@@ -10,23 +10,23 @@
#include "net/url_request/url_request_test_util.h"
#include "testing/gmock/include/gmock/gmock.h"
-namespace data_reduction_proxy {
+using testing::_;
-TestDataReductionProxyConfig::TestDataReductionProxyConfig()
- : TestDataReductionProxyConfig(DataReductionProxyParams::kAllowed |
- DataReductionProxyParams::kFallbackAllowed |
- DataReductionProxyParams::kPromoAllowed) {
-}
+namespace data_reduction_proxy {
-TestDataReductionProxyConfig::TestDataReductionProxyConfig(int flags)
+TestDataReductionProxyConfig::TestDataReductionProxyConfig(
+ int params_flags,
+ unsigned int params_definitions,
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ net::NetLog* net_log,
+ DataReductionProxyConfigurator* configurator,
+ DataReductionProxyEventStore* event_store)
: DataReductionProxyConfig(
- scoped_ptr<TestDataReductionProxyParams>(
- new TestDataReductionProxyParams(
- flags,
- TestDataReductionProxyParams::HAS_EVERYTHING &
- ~TestDataReductionProxyParams::HAS_DEV_ORIGIN &
- ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN))
- .Pass()) {
+ task_runner, task_runner, net_log,
+ make_scoped_ptr(
+ new TestDataReductionProxyParams(params_flags, params_definitions))
+ .Pass(),
+ configurator, event_store) {
network_interfaces_.reset(new net::NetworkInterfaceList());
}
@@ -62,24 +62,38 @@ void TestDataReductionProxyConfig::SetStateForTest(
enabled_by_user_ = enabled_by_user;
alternative_enabled_by_user_ = alternative_enabled_by_user;
restricted_by_carrier_ = restricted_by_carrier;
- SetProxyConfigs(enabled_by_user_, alternative_enabled_by_user_,
- restricted_by_carrier_, at_startup);
+ UpdateConfigurator(enabled_by_user_, alternative_enabled_by_user_,
+ restricted_by_carrier_, at_startup);
}
-MockDataReductionProxyConfig::MockDataReductionProxyConfig(int flags)
- : TestDataReductionProxyConfig(flags) {
+MockDataReductionProxyConfig::MockDataReductionProxyConfig(
+ int params_flags,
+ unsigned int params_definitions,
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ net::NetLog* net_log,
+ DataReductionProxyConfigurator* configurator,
+ DataReductionProxyEventStore* event_store)
+ : TestDataReductionProxyConfig(
+ params_flags, params_definitions, task_runner, net_log, configurator,
+ event_store) {
}
MockDataReductionProxyConfig::~MockDataReductionProxyConfig() {
}
-void MockDataReductionProxyConfig::SetProxyConfigs(bool enabled,
- bool alternative_enabled,
- bool restricted,
- bool at_startup) {
+void MockDataReductionProxyConfig::UpdateConfigurator(bool enabled,
+ bool alternative_enabled,
+ bool restricted,
+ bool at_startup) {
EXPECT_CALL(*this, LogProxyState(enabled, restricted, at_startup)).Times(1);
- DataReductionProxyConfig::SetProxyConfigs(enabled, alternative_enabled,
- restricted, at_startup);
+ DataReductionProxyConfig::UpdateConfigurator(enabled, alternative_enabled,
+ restricted, at_startup);
+}
+
+void MockDataReductionProxyConfig::HandleProbeResponse(
+ const std::string& response,
+ const net::URLRequestStatus& status) {
+ DataReductionProxyConfig::HandleProbeResponse(response, status);
}
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698