components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc - Issue 893003002: Data Reduction Proxy class ownership updates and Settings cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

Issue 893003002: Data Reduction Proxy class ownership updates and Settings cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc ('K') | « components/data_reduction_proxy/core/browser/BUILD.gn ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

index 8dac81b34c17ddf26a710183163e5516b97e7c58..8907c65a4d386c5d2d9144b9de3a76ae29eeb2ae 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

@@ -13,7 +13,6 @@

#include "base/strings/stringprintf.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.h"

-#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.h"

@@ -119,7 +118,8 @@ class DataReductionProxyProtocolTest : public testing::Test {

// to requests.

context_->set_http_user_agent_settings(&http_user_agent_settings_);

usage_stats_.reset(new DataReductionProxyUsageStats(

- test_context_->config()->params(), test_context_->settings(),

+ test_context_->config()->params(),

+ test_context_->data_reduction_proxy_service()->GetWeakPtr(),

test_context_->task_runner()));

DataReductionProxyInterceptor* interceptor =