chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc - Issue 893003002: Data Reduction Proxy class ownership updates and Settings cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

Issue 893003002: Data Reduction Proxy class ownership updates and Settings cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc ('K') | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.cc ('k') | chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

index 77ebed8031015b1fc0ab01778dae74cd6d22d3e3..d36deb45f5a8f47ef566073a10a878c9006f1e89 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

@@ -18,8 +18,8 @@ using data_reduction_proxy::DataReductionProxySettings;

class DataReductionProxyChromeSettingsTest : public testing::Test {

public:

void SetUp() override {

- drp_chrome_settings_ = make_scoped_ptr(new DataReductionProxyChromeSettings(

- make_scoped_ptr(new DataReductionProxyParams(0))));

+ drp_chrome_settings_ =

+ make_scoped_ptr(new DataReductionProxyChromeSettings());

dict_ = make_scoped_ptr(new DictionaryValue());

mock_pref_service_ = make_scoped_ptr(new TestingPrefServiceSimple());