components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h - Issue 893003002: Data Reduction Proxy class ownership updates and Settings cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

Issue 893003002: Data Reduction Proxy class ownership updates and Settings cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

index 116cdc72c2fb27d999061ab5ce6ee775be02573d..6edd2ce4a3a06ce23735e8f82f7156613aacb25a 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

@@ -40,9 +40,9 @@ class URLRequest;

namespace data_reduction_proxy {

class DataReductionProxyConfigurator;

+class DataReductionProxyIOData;

class DataReductionProxyParams;

class DataReductionProxyRequestOptions;

-class DataReductionProxyStatisticsPrefs;

class DataReductionProxyUsageStats;

// DataReductionProxyNetworkDelegate is a LayeredNetworkDelegate that wraps a

@@ -68,9 +68,9 @@ class DataReductionProxyNetworkDelegate : public net::LayeredNetworkDelegate {

// Initializes member variables to record data reduction proxy prefs and

// report UMA.

- void InitStatisticsPrefsAndUMA(

+ void InitIODataAndUMA(

scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,

- const base::WeakPtr<DataReductionProxyStatisticsPrefs>& statistics_prefs,

+ DataReductionProxyIOData* io_data,

BooleanPrefMember* data_reduction_proxy_enabled,

DataReductionProxyUsageStats* usage_stats);

@@ -150,8 +150,7 @@ class DataReductionProxyNetworkDelegate : public net::LayeredNetworkDelegate {

DataReductionProxyRequestOptions* data_reduction_proxy_request_options_;

- base::WeakPtr<DataReductionProxyStatisticsPrefs>

- data_reduction_proxy_statistics_prefs_;

+ DataReductionProxyIOData* data_reduction_proxy_io_data_;

const DataReductionProxyConfigurator* configurator_;