Data Reduction Proxy class ownership updates and Settings cleanup

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
index bce19bac82dd4e06c02fc6605e9e4b0dfd310bc6..a1d86f99f0c75e5140f674c082935c84993d68bf 100644
--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
@@ -5,24 +5,21 @@
 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
 
-#include "base/memory/scoped_ptr.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
 #include "components/keyed_service/core/keyed_service.h"
 
-namespace base {
 class PrefService;
+
+namespace base {
+class SingleThreadTaskRunner;
 }
 
 namespace data_reduction_proxy {
-class DataReductionProxyConfigurator;
 class DataReductionProxyIOData;
-class DataReductionProxyEventStore;
-class DataReductionProxyParams;
 }
 
 namespace net {
-class NetLog;
 class URLRequestContextGetter;
 }
 
@@ -34,22 +31,22 @@ class DataReductionProxyChromeSettings
     : public data_reduction_proxy::DataReductionProxySettings,
       public KeyedService {
  public:
-  // Constructs a settings object with the given configuration parameters.
-  // Construction and destruction must happen on the UI thread.
-  explicit DataReductionProxyChromeSettings(
-      scoped_ptr<data_reduction_proxy::DataReductionProxyParams> params);
+  // Constructs a settings object. Construction and destruction must happen on
+  // the UI thread.
+  DataReductionProxyChromeSettings();
 
   // Destructs the settings object.
   ~DataReductionProxyChromeSettings() override;
 
-  // Initialize the settings object with the given configurator, prefs services,
-  // and request context. Settings takes ownership of statistics prefs from
-  // |io_data|.
+  void Shutdown() override;

[bengr, 2015/02/17 18:10:24]

Add comments that say what these overrides override.

[jeremyim, 2015/02/19 21:03:44]

Done.

+
+  // Initialize the settings object with the given io_data, prefs services,
+  // request context getter, and task runner.
   void InitDataReductionProxySettings(
       data_reduction_proxy::DataReductionProxyIOData* io_data,
       PrefService* profile_prefs,
-      PrefService* local_state_prefs,
-      net::URLRequestContextGetter* request_context);
+      net::URLRequestContextGetter* request_context,
+      const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner);
 
   // Gets the client type for the data reduction proxy.
   static data_reduction_proxy::Client GetClient();