Data Reduction Proxy class ownership updates and Settings cleanup

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
 
-#include "base/memory/scoped_ptr.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
 #include "components/keyed_service/core/keyed_service.h"
 
+class PrefService;
+
 namespace base {
-class PrefService;
+class SingleThreadTaskRunner;
 }
 
 namespace data_reduction_proxy {
-class DataReductionProxyConfigurator;
 class DataReductionProxyIOData;
-class DataReductionProxyEventStore;
-class DataReductionProxyParams;
 }
 
 namespace net {
-class NetLog;
 class URLRequestContextGetter;
 }
 
 class PrefService;
 
 // Data reduction proxy settings class suitable for use with a Chrome browser.
 // It is keyed to a browser context.
 class DataReductionProxyChromeSettings
     : public data_reduction_proxy::DataReductionProxySettings,
       public KeyedService {
  public:
-  // Constructs a settings object with the given configuration parameters.
-  // Construction and destruction must happen on the UI thread.
-  explicit DataReductionProxyChromeSettings(
-      scoped_ptr<data_reduction_proxy::DataReductionProxyParams> params);
+  // Constructs a settings object. Construction and destruction must happen on
+  // the UI thread.
+  DataReductionProxyChromeSettings();
 
   // Destructs the settings object.
   ~DataReductionProxyChromeSettings() override;
 
-  // Initialize the settings object with the given configurator, prefs services,
-  // and request context. Settings takes ownership of statistics prefs from
-  // |io_data|.
+  // Overrides KeyedService::Shutdown:
+  void Shutdown() override;
+
+  // Initialize the settings object with the given io_data, prefs services,
+  // request context getter, and task runner.
   void InitDataReductionProxySettings(
       data_reduction_proxy::DataReductionProxyIOData* io_data,
       PrefService* profile_prefs,
-      PrefService* local_state_prefs,
-      net::URLRequestContextGetter* request_context);
+      net::URLRequestContextGetter* request_context,

[bengr, 2015/02/20 00:00:36]

nit: request_context_getter

[jeremyim, 2015/02/20 02:17:17]

Done.

+      const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner);
 
   // Gets the client type for the data reduction proxy.
   static data_reduction_proxy::Client GetClient();
 
   // Public for testing.
   void MigrateDataReductionProxyOffProxyPrefs(PrefService* prefs);
 
  private:
   // Registers the DataReductionProxyEnabled synthetic field trial with
   // the group |data_reduction_proxy_enabled|.
   void RegisterSyntheticFieldTrial(bool data_reduction_proxy_enabled);
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings);
 };
 
 #endif  // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_