Data Reduction Proxy class ownership updates and Settings cleanup

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
 
-#include "base/memory/scoped_ptr.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
 #include "components/keyed_service/core/keyed_service.h"
 
 namespace base {
 class PrefService;
 }
 
 namespace data_reduction_proxy {
-class DataReductionProxyConfigurator;
+class DataReductionProxyConfig;
 class DataReductionProxyIOData;
 class DataReductionProxyEventStore;
-class DataReductionProxyParams;
-}
-
-namespace net {
-class NetLog;
-class URLRequestContextGetter;
 }
 
 class PrefService;
 
 // Data reduction proxy settings class suitable for use with a Chrome browser.
 // It is keyed to a browser context.
 class DataReductionProxyChromeSettings

[bengr, 2015/02/03 21:51:57]

Hmm, I guess I was expecting that you'd constuct a threadsafe config object for
settings construction and pass ownership of it to io_data and have setting
retain a WeakPtr. Please work through the construction/destruction ordering of
settings, profile, UI thread and IO thread to see if your approach is viable.

     : public data_reduction_proxy::DataReductionProxySettings,
       public KeyedService {
  public:
   // Constructs a settings object with the given configuration parameters.

[bengr, 2015/02/03 21:51:57]

Update the comment.

   // Construction and destruction must happen on the UI thread.
-  explicit DataReductionProxyChromeSettings(
-      scoped_ptr<data_reduction_proxy::DataReductionProxyParams> params);
+  DataReductionProxyChromeSettings();
 
   // Destructs the settings object.
   ~DataReductionProxyChromeSettings() override;
 
-  // Initialize the settings object with the given configurator, prefs services,
-  // and request context.
+  // Initialize the settings object with the given prefs services, and io_data.
   void InitDataReductionProxySettings(
       data_reduction_proxy::DataReductionProxyIOData* io_data,

[bengr, 2015/02/03 21:51:57]

Hmm. I'm worried that initializing the settings object after io_data creation
may be too late. Does this work on Android, e.g.?

       PrefService* profile_prefs,
-      PrefService* local_state_prefs,
-      net::URLRequestContextGetter* request_context);
+      PrefService* local_state_prefs);
 
   // Gets the client type for the data reduction proxy.
   static data_reduction_proxy::Client GetClient();
 
  private:
   // Registers the DataReductionProxyEnabled synthetic field trial with
   // the group |data_reduction_proxy_enabled|.
   void RegisterSyntheticFieldTrial(bool data_reduction_proxy_enabled);
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings);
 };
 
 #endif  // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_