Source/core/html/shadow/MediaControls.cpp - Issue 892963003: Ensure media control goes to transparent(hide) after seek by touch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 892963003: Ensure media control goes to transparent(hide) after seek by touch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Schedule the hover state update in playbackProgressed only if media control bar is opaque Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/shadow/MediaControls.cpp

diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp

index bd04ac6ae8d41c0d3a59898d537b5670bfb522cc..e11cf5e919648ed65a6a2aab52165606a410e250 100644

--- a/Source/core/html/shadow/MediaControls.cpp

+++ b/Source/core/html/shadow/MediaControls.cpp

@@ -34,6 +34,7 @@

#include "core/html/HTMLMediaElement.h"

#include "core/html/MediaController.h"

#include "core/layout/LayoutTheme.h"

+#include "core/page/EventHandler.h"

namespace blink {

@@ -273,6 +274,9 @@ void MediaControls::playbackProgressed()

m_timeline->setPosition(mediaElement().currentTime());

updateCurrentTimeDisplay();

+ if (m_panel->isOpaque() && document().frame())

+ document().frame()->eventHandler().scheduleHoverStateUpdate();

fs 2015/02/02 15:22:28 Did you consider doing something like: unsigned b

if (shouldHideMediaControls())

makeTransparent();

}

« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »