Source/core/html/shadow/MediaControls.h - Issue 892963003: Ensure media control goes to transparent(hide) after seek by touch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.h

Issue 892963003: Ensure media control goes to transparent(hide) after seek by touch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/media/video-controls-auto-hide-after-seek-by-touch.html ('K') | « LayoutTests/media/video-controls-auto-hide-after-seek-by-touch-expected.txt ('k') | Source/core/html/shadow/MediaControls.cpp » ('j') | Source/core/html/shadow/MediaControls.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/shadow/MediaControls.h

diff --git a/Source/core/html/shadow/MediaControls.h b/Source/core/html/shadow/MediaControls.h

index 18234b7c5f29d6588a82cb054c211926062defd1..177338e6428d58f833f9c161321ac5f7aa91846c 100644

--- a/Source/core/html/shadow/MediaControls.h

+++ b/Source/core/html/shadow/MediaControls.h

@@ -85,6 +85,7 @@ private:

void updatePlayState();

enum HideBehaviorFlags {

+ IgnoreNone = 0,

IgnoreVideoHover = 1 << 0,

IgnoreFocus = 1 << 1,

IgnoreControlsHover = 1 << 2

@@ -137,6 +138,7 @@ private:

bool m_isMouseOverControls : 1;

bool m_isPausedForScrubbing : 1;

bool m_wasLastEventTouch : 1;

+ unsigned m_HideTimerBehaviorFlags;

fs 2015/02/06 13:43:32 m_hideTimer... Also, move it up to just after m_h

};

DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());