Ensure media control goes to transparent(hide) after seek by touch

Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 50 matching lines @@
     , m_toggleClosedCaptionsButton(nullptr)
     , m_fullScreenButton(nullptr)
     , m_castButton(nullptr)
     , m_overlayCastButton(nullptr)
     , m_durationDisplay(nullptr)
     , m_enclosure(nullptr)
     , m_hideMediaControlsTimer(this, &MediaControls::hideMediaControlsTimerFired)
     , m_isMouseOverControls(false)
     , m_isPausedForScrubbing(false)
     , m_wasLastEventTouch(false)
+    , m_HideTimerBehaviorFlags(IgnoreNone)
 {
 }
 
 PassRefPtrWillBeRawPtr<MediaControls> MediaControls::create(HTMLMediaElement& mediaElement)
 {
     RefPtrWillBeRawPtr<MediaControls> controls = adoptRefWillBeNoop(new MediaControls(mediaElement));
     controls->setShadowPseudoId(AtomicString("-webkit-media-controls", AtomicString::ConstructFromLiteral));
     controls->initializeControls();
     return controls.release();
 }
@@ skipping 389 matching lines @@
             startHideMediaControlsTimer();
         return;
     }
 }
 
 void MediaControls::hideMediaControlsTimerFired(Timer<MediaControls>*)
 {
     if (mediaElement().togglePlayStateWillPlay())
         return;
 
-    unsigned behaviorFlags = IgnoreFocus | IgnoreVideoHover;
-    if (m_wasLastEventTouch) {
-        behaviorFlags |= IgnoreControlsHover;
-    }
-    if (!shouldHideMediaControls(behaviorFlags))
+    m_HideTimerBehaviorFlags |= IgnoreFocus;
+    m_HideTimerBehaviorFlags |= IgnoreVideoHover;

[fs, 2015/02/06 13:43:32]

I'd make this similar to the previous PS:

unsigned behaviorFlags = m_hideTimerBehaviorFlags | ...;

I.e. don't mutate the member here - just read it and pass it.

Alternatively you could clear it here (first in the method) too, but if it isn't
mutated it should be ok to leave that to start...().

[william.xie1, 2015/02/06 14:59:20]

Done.

+    if (!shouldHideMediaControls(m_HideTimerBehaviorFlags))
         return;
 
     makeTransparent();
     m_overlayCastButton->hide();
 }
 
 void MediaControls::startHideMediaControlsTimer()
 {
+    if (m_wasLastEventTouch) {

[fs, 2015/02/06 13:43:32]

Get rid of m_wasLastEventTouch, and either pass that to
startHideMediaControlsTimer:

startHideMediaControlsTimer(bool triggeredByTouch)

or determine the behavior flags in defaultEventHandler and pass that.

startHideMediaControlsTimer(unsigned behaviorFlags)

+        m_HideTimerBehaviorFlags = IgnoreControlsHover;
+    }
     m_hideMediaControlsTimer.startOneShot(timeWithoutMouseMovementBeforeHidingMediaControls, FROM_HERE);
 }
 
 void MediaControls::stopHideMediaControlsTimer()
 {
     m_hideMediaControlsTimer.stop();
+    m_HideTimerBehaviorFlags = IgnoreNone;
 }
 
 void MediaControls::resetHideMediaControlsTimer()
 {
     stopHideMediaControlsTimer();
     if (!mediaElement().paused())
         startHideMediaControlsTimer();
 }
 
 
@@ skipping 56 matching lines @@
     visitor->trace(m_toggleClosedCaptionsButton);
     visitor->trace(m_fullScreenButton);
     visitor->trace(m_durationDisplay);
     visitor->trace(m_enclosure);
     visitor->trace(m_castButton);
     visitor->trace(m_overlayCastButton);
     HTMLDivElement::trace(visitor);
 }
 
 }