Ensure media control goes to transparent(hide) after seek by touch

Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 16 matching lines @@
 #include "config.h"
 #include "core/html/shadow/MediaControls.h"
 
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/ClientRect.h"
 #include "core/events/MouseEvent.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/MediaController.h"
 #include "core/layout/LayoutTheme.h"
+#include "core/page/EventHandler.h"
 
 namespace blink {
 
 // If you change this value, then also update the corresponding value in
 // LayoutTests/media/media-controls.js.
 static const double timeWithoutMouseMovementBeforeHidingMediaControls = 3;
 
 static bool fullscreenIsSupported(const Document& document)
 {
     return !document.settings() || document.settings()->fullscreenSupported();
@@ skipping 185 matching lines @@
 void MediaControls::makeTransparent()
 {
     m_panel->makeTransparent();
 }
 
 bool MediaControls::shouldHideMediaControls(unsigned behaviorFlags) const
 {
     // Never hide for a media element without visual representation.
     if (!mediaElement().hasVideo() || mediaElement().isPlayingRemotely())
         return false;
+
+    // Update hover status before check it
+    if (document().frame())
+        document().frame()->eventHandler().scheduleHoverStateUpdate();

[fs, 2015/02/02 13:13:46]

All this does is to start a timer, so this doesn't seem to do what the comment
says.

[william.xie1, 2015/02/02 14:29:18]

Hi fs,
yes, here it schedule a time for hover status update, after the the timer fired,
m_panel->hovered() will get the latest state.

+
     // Don't hide if the mouse is over the controls.
     const bool ignoreControlsHover = behaviorFlags & IgnoreControlsHover;
     if (!ignoreControlsHover && m_panel->hovered())
         return false;
     // Don't hide if the mouse is over the video area.
     const bool ignoreVideoHover = behaviorFlags & IgnoreVideoHover;
     if (!ignoreVideoHover && m_isMouseOverControls)
         return false;
     // Don't hide if focus is on the HTMLMediaElement or within the
     // controls/shadow tree. (Perform the checks separately to avoid going
@@ skipping 14 matching lines @@
     updateCurrentTimeDisplay();
 
     startHideMediaControlsTimer();
 }
 
 void MediaControls::playbackProgressed()
 {
     m_timeline->setPosition(mediaElement().currentTime());
     updateCurrentTimeDisplay();
 
-    if (shouldHideMediaControls())
+    if (m_panel->isOpaque() && shouldHideMediaControls())

[fs, 2015/02/02 13:13:46]

makeTransparent already checks this, so this just seems to make the predicate
more confusing. (I guess you put it here to avoid scheduling the timer above
over-and-over?)

[william.xie1, 2015/02/02 14:29:18]

Yes, correct, to avoid schedule the hover state update time over-and-over.

         makeTransparent();
 }
 
 void MediaControls::playbackStopped()
 {
     updatePlayState();
     m_timeline->setPosition(mediaElement().currentTime());
     updateCurrentTimeDisplay();
     makeOpaque();
 
@@ skipping 278 matching lines @@
     visitor->trace(m_toggleClosedCaptionsButton);
     visitor->trace(m_fullScreenButton);
     visitor->trace(m_durationDisplay);
     visitor->trace(m_enclosure);
     visitor->trace(m_castButton);
     visitor->trace(m_overlayCastButton);
     HTMLDivElement::trace(visitor);
 }
 
 }