runtime/lib/timer_impl.dart - Issue 892963002: Reduce timer stack overhead by getting immediate callback and run it, instead of calling through fu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/timer_impl.dart

Issue 892963002: Reduce timer stack overhead by getting immediate callback and run it, instead of calling through fu… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/timer_impl.dart

diff --git a/runtime/lib/timer_impl.dart b/runtime/lib/timer_impl.dart

index 4df37cd87748313744415dd28ccdafa474872f30..2c5674572d7a9e2509c65bfadf9b6e93caeb0cc5 100644

--- a/runtime/lib/timer_impl.dart

+++ b/runtime/lib/timer_impl.dart

@@ -396,7 +396,10 @@ class _Timer implements Timer {

timer._addTimerToHeap();

}

// Execute pending micro tasks.

- _runPendingImmediateCallback();

+ var immediateCallback = _removePendingImmediateCallback();

+ if (immediateCallback != null) {

+ immediateCallback();

+ }

}

} finally {

« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | no next file » | no next file with comments »