content/renderer/menu_item_builder.cc - Issue 892953002: Show icons for custom menuitems in contextmenu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/menu_item_builder.cc

Issue 892953002: Show icons for custom menuitems in contextmenu. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/menu_item_builder.cc

diff --git a/content/renderer/menu_item_builder.cc b/content/renderer/menu_item_builder.cc

index 7db359296367b524458039cc1b28e0ee5aeffebe..cccdb13ad1950bb91d2a02f45adb7df3205d98b0 100644

--- a/content/renderer/menu_item_builder.cc

+++ b/content/renderer/menu_item_builder.cc

@@ -5,6 +5,7 @@

#include "content/renderer/menu_item_builder.h"

#include "content/public/common/menu_item.h"

+#include "url/gurl.h"

namespace content {

@@ -12,7 +13,7 @@ MenuItem MenuItemBuilder::Build(const blink::WebMenuItemInfo& item) {

MenuItem result;

result.label = item.label;

- result.icon = item.icon;

+ result.icon = GURL(item.icon);

result.tool_tip = item.toolTip;

result.type = static_cast<MenuItem::Type>(item.type);

result.action = item.action;