chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc - Issue 892953002: Show icons for custom menuitems in contextmenu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc

Issue 892953002: Show icons for custom menuitems in contextmenu. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Scaled to 16x16 Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc » ('j') | components/renderer_context_menu/render_view_context_menu_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc

diff --git a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc

index 608df4969cdb93b3e1c03a8fa9129ec99644ef8f..0b2eff30f6b908223caf9f94b52736cd89243cf9 100644

--- a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc

+++ b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc

@@ -69,6 +69,7 @@ class MockRenderViewContextMenu : public ui::SimpleMenuModel::Delegate,

bool enabled,

bool hidden,

const base::string16& title) override {}

+ void SetIcon(int command_id, const gfx::Image& icon) override {};

dcheng 2015/02/18 17:03:27 Nit: remove superfluous semicolon, here and elsewh

pals 2015/02/23 10:23:15 Done.

RenderViewHost* GetRenderViewHost() const override { return NULL; }

content::BrowserContext* GetBrowserContext() const override {

return profile_.get();