Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 892933002: Filter out log lines when parsing output of --gtest_list_tests. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
Reviewers:
jamesr, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Filter out log lines when parsing output of --gtest_list_tests. This patch makes the Chromium apptest runner resilient to missing apps (e.g. tracing.mojo) polluting the output of mojo_shell that it tries to parse. BUG=450356 TBR=jamesr@chromium.org Committed: https://crrev.com/554d1a97e618d951e5b30132b69ec51515d6839d Cr-Commit-Position: refs/heads/master@{#314134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M mojo/tools/gtest.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ppi
Hi Ben, ptal.
5 years, 10 months ago (2015-02-02 11:12:05 UTC) #2
qsr
lgtm
5 years, 10 months ago (2015-02-02 12:01:39 UTC) #3
ppi
Thanks. I'm sending out https://codereview.chromium.org/892103004/ so that we don't need to wait or TBR such ...
5 years, 10 months ago (2015-02-02 12:21:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892933002/1
5 years, 10 months ago (2015-02-02 12:23:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 13:26:14 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/554d1a97e618d951e5b30132b69ec51515d6839d Cr-Commit-Position: refs/heads/master@{#314134}
5 years, 10 months ago (2015-02-02 13:27:12 UTC) #9
jamesr
Shouldn't this sort of thing be in some generic part of the apptest framework in ...
5 years, 10 months ago (2015-02-03 05:03:39 UTC) #10
ppi
5 years, 10 months ago (2015-02-03 08:38:11 UTC) #11
Message was sent while issue was closed.
I think so. As discussed on https://codereview.chromium.org/878933003/ , this
doesn't seem straightforward.

Filed http://crbug.com/454718 to follow up on that.

Powered by Google App Engine
This is Rietveld 408576698