Issue 89293002: Trying to add the same scaled image twice shouldn't assert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 89293002: Trying to add the same scaled image twice shouldn't assert. (Closed)

Created:
7 years ago by mtklein

Modified:
7 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Trying to add the same scaled image twice shouldn't assert. This unbreaks bench_pictures --multi foo for me. BUG=skia:1868 Committed: http://code.google.com/p/skia/source/detail?r=12422

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -19 lines)			Patch
M	src/core/SkScaledImageCache.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	8 chunks	+29 lines, -18 lines	0 comments	Download
M	tests/ImageCacheTest.cpp	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

mtklein

Ended up being easier to go your way and return the other guy's ID.

7 years ago (2013-11-26 22:01:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/89293002/1

7 years ago (2013-11-27 20:09:54 UTC) #3

Message was sent while issue was closed.

Change committed as 12422