Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: pkg/analysis_server/lib/src/search/search_domain.dart

Issue 892913004: Fix type hierarchy when there is no element. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/search/search_domain.dart
diff --git a/pkg/analysis_server/lib/src/search/search_domain.dart b/pkg/analysis_server/lib/src/search/search_domain.dart
index 8f550b60b99cef832ed95abbba600c8da37b09f3..01fd53e49a6bee29d928de7ee54af0ef088d8b04 100644
--- a/pkg/analysis_server/lib/src/search/search_domain.dart
+++ b/pkg/analysis_server/lib/src/search/search_domain.dart
@@ -131,13 +131,14 @@ class SearchDomainHandler implements protocol.RequestHandler {
Future getTypeHierarchy(protocol.Request request) async {
var params = new protocol.SearchGetTypeHierarchyParams.fromRequest(request);
await server.onAnalysisComplete;
- // prepare parameters
+ // prepare element
List<Element> elements =
server.getElementsAtOffset(params.file, params.offset);
if (elements.isEmpty) {
protocol.Response response =
new protocol.SearchGetTypeHierarchyResult().toResponse(request.id);
server.sendResponse(response);
+ return;
}
Element element = elements.first;
// prepare type hierarchy
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698