Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: runtime/vm/service.cc

Issue 892913003: Rename the get* methods in preparation for removing them. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: one more test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/test/vm_metrics_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index f6ba57a66f4a237230c0b0351f413aaa24aa3b48..614d43815f6532ca8c5a26fe8f2801d3b4f37045 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -953,7 +953,12 @@ void Service::HandleIsolateMessageNew(Isolate* isolate, const Array& msg) {
if (e_handler != NULL) {
EmbedderHandleMessage(e_handler, &js);
} else {
- PrintError(&js, "Unrecognized method: %s", method.ToCString());
+ if (FindRootMessageHandlerNew(method.ToCString()) != NULL) {
+ PrintError(&js, "%s expects no 'isolate' parameter\n",
+ method.ToCString());
+ } else {
+ PrintError(&js, "Unrecognized method: %s", method.ToCString());
+ }
}
js.PostReply();
} else {
@@ -3085,7 +3090,12 @@ void Service::HandleRootMessageNew(const Array& msg) {
if (e_handler != NULL) {
EmbedderHandleMessage(e_handler, &js);
} else {
- PrintError(&js, "Unrecognized path");
+ if (FindIsolateMessageHandlerNew(method.ToCString()) != NULL) {
+ PrintError(&js, "%s expects an 'isolate' parameter\n",
+ method.ToCString());
+ } else {
+ PrintError(&js, "Unrecognized method: %s", method.ToCString());
+ }
}
js.PostReply();
} else {
« no previous file with comments | « runtime/observatory/test/vm_metrics_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698