Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 892903003: Download and copy shell binary on Android as well as Linux. (Closed)

Created:
5 years, 10 months ago by blundell
Modified:
5 years, 10 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Download and copy shell binary on Android as well as Linux. This CL augments download_shell_binary.py to download the prebuilt shell for Android as well as for Linux. It also augments the copy_mojo_shell build step to work on Android as well as Linux. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/817a264fb65e6359a805c2e14d465ce6906e50dc

Patch Set 1 #

Total comments: 4

Patch Set 2 : Response to review #

Total comments: 2

Patch Set 3 : Response to review #

Total comments: 2

Patch Set 4 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -26 lines) Patch
M mojo/public/tools/BUILD.gn View 1 chunk +12 lines, -3 lines 0 comments Download
M mojo/public/tools/download_shell_binary.py View 1 2 3 3 chunks +32 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
blundell
5 years, 10 months ago (2015-02-06 14:30:28 UTC) #2
qsr
https://codereview.chromium.org/892903003/diff/1/mojo/public/tools/download_shell_binary.py File mojo/public/tools/download_shell_binary.py (right): https://codereview.chromium.org/892903003/diff/1/mojo/public/tools/download_shell_binary.py#newcode44 mojo/public/tools/download_shell_binary.py:44: stamp_file.write(version) Are you missing a return value after this? ...
5 years, 10 months ago (2015-02-06 14:37:37 UTC) #3
blundell
https://codereview.chromium.org/892903003/diff/1/mojo/public/tools/download_shell_binary.py File mojo/public/tools/download_shell_binary.py (right): https://codereview.chromium.org/892903003/diff/1/mojo/public/tools/download_shell_binary.py#newcode44 mojo/public/tools/download_shell_binary.py:44: stamp_file.write(version) On 2015/02/06 14:37:37, qsr wrote: > Are you ...
5 years, 10 months ago (2015-02-06 14:41:09 UTC) #4
qsr
LGTM with nits. https://codereview.chromium.org/892903003/diff/20001/mojo/public/tools/download_shell_binary.py File mojo/public/tools/download_shell_binary.py (right): https://codereview.chromium.org/892903003/diff/20001/mojo/public/tools/download_shell_binary.py#newcode25 mojo/public/tools/download_shell_binary.py:25: prebuilt_file_path = os.path.join(current_path, "prebuilt") Maybe create ...
5 years, 10 months ago (2015-02-06 14:48:13 UTC) #5
blundell
https://codereview.chromium.org/892903003/diff/20001/mojo/public/tools/download_shell_binary.py File mojo/public/tools/download_shell_binary.py (right): https://codereview.chromium.org/892903003/diff/20001/mojo/public/tools/download_shell_binary.py#newcode25 mojo/public/tools/download_shell_binary.py:25: prebuilt_file_path = os.path.join(current_path, "prebuilt") On 2015/02/06 14:48:12, qsr wrote: ...
5 years, 10 months ago (2015-02-06 15:01:04 UTC) #7
qsr
LGTM with nits. https://codereview.chromium.org/892903003/diff/40001/mojo/public/tools/download_shell_binary.py File mojo/public/tools/download_shell_binary.py (right): https://codereview.chromium.org/892903003/diff/40001/mojo/public/tools/download_shell_binary.py#newcode23 mojo/public/tools/download_shell_binary.py:23: prebuilt_file_path = os.path.join(current_path, "prebuilt") Those should ...
5 years, 10 months ago (2015-02-06 15:03:44 UTC) #8
blundell
https://codereview.chromium.org/892903003/diff/40001/mojo/public/tools/download_shell_binary.py File mojo/public/tools/download_shell_binary.py (right): https://codereview.chromium.org/892903003/diff/40001/mojo/public/tools/download_shell_binary.py#newcode23 mojo/public/tools/download_shell_binary.py:23: prebuilt_file_path = os.path.join(current_path, "prebuilt") On 2015/02/06 15:03:44, qsr wrote: ...
5 years, 10 months ago (2015-02-06 15:12:01 UTC) #10
blundell
5 years, 10 months ago (2015-02-06 15:14:21 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
817a264fb65e6359a805c2e14d465ce6906e50dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698