Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 892903002: Remove -webkit-mask-*. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove -webkit-mask-*. This is for doing masking based off the alpha channel of an image. This is a feature we want to support, but we want a more general imperative API that the declarative thing is built on top of. In the meantime, the code is getting in our way and the feature was already broken (likely from before making sky public). We just paint the mask image on top instead of doing the actual masking. This patch just removes the parsing. Followup patches will remove the implementation code. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9c79fb7d4e0fdddb71dedcc7c15e3b4b099c0954

Patch Set 1 #

Patch Set 2 : fix goofups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -348 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 3 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/animation/css/CSSAnimatableValueFactory.cpp View 3 chunks +4 lines, -27 lines 0 comments Download
M sky/engine/core/animation/css/CSSPropertyEquality.cpp View 1 2 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 1 9 chunks +19 lines, -87 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 3 chunks +0 lines, -19 lines 0 comments Download
M sky/engine/core/css/StylePropertySerializer.cpp View 5 chunks +5 lines, -25 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 22 chunks +27 lines, -104 lines 0 comments Download
M sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp View 4 chunks +0 lines, -33 lines 0 comments Download
M sky/engine/core/css/resolver/CSSToStyleMap.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResourceLoader.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 10 months ago (2015-02-02 02:41:05 UTC) #2
ojan
5 years, 10 months ago (2015-02-02 02:45:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9c79fb7d4e0fdddb71dedcc7c15e3b4b099c0954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698