Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 8929009: Revert 102683 - Revert 96912 - Always call setActive() in WebViewImpl::setFocus(), (Closed)

Created:
9 years, 2 months ago by Nate Chapin
Modified:
9 years, 2 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Revert 102683 - Revert 96912 - Always call setActive() in WebViewImpl::setFocus(), not just when enabling focus. https://bugs.webkit.org/show_bug.cgi?id=65220 Reviewed by Darin Fisher. * WebKit.gyp: * WebKit.gypi: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus): * tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp. (WebKit::FrameTestHelpers::registerMockedURLLoad): (WebKit::FrameTestHelpers::loadFrame): (WebKit::FrameTestHelpers::defaultWebFrameClient): (WebKit::FrameTestHelpers::defaultWebViewClient): (WebKit::FrameTestHelpers::createWebViewAndLoad): * tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp. * tests/WebFrameTest.cpp: * tests/WebViewTest.cpp: Added. TBR=japhet@chromium.org Review URL: http://codereview.chromium.org/8895026 TBR=japhet@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -116 lines) Patch
M Source/WebKit/chromium/WebKit.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/WebKit.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 13 chunks +19 lines, -116 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nate Chapin
9 years, 2 months ago (2011-12-13 18:19:23 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698